fix(cli-repl): account for possibility of process.exit() throwing under coverage MONGOSH-1943
#2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder coverage When running under `nyc` for coverage generation, the process's `process.exit()` internals get monkey-patched to give `nyc` the opportunity to write coverage data as part of that operation. However, for processes running under changed working directories, `nyc` may try to write to an incorrect directory, making the `fs.writeFile()` call fail with an exception, and so `process.exit()` may not actually stop the process. This commit adds a `process.abort()` call to make that accounts for this situation, as well as improved debugging for it.
This was referenced Dec 12, 2024
gagik
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under
nycfor coverage generation, the process'sprocess.exit()internals get monkey-patched to givenycthe opportunity to write coverage data as part of that operation. However, for processes running under changed working directories,nycmay try to write to an incorrect directory, making thefs.writeFile()call fail with an exception, and soprocess.exit()may not actually stop the process.This commit adds a
process.abort()call to make that accounts for this situation, as well as improved debugging for it.